Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Migrate from buildpack.yml to environment variables #76

Merged
merged 14 commits into from
Dec 10, 2020
Merged

RFC: Migrate from buildpack.yml to environment variables #76

merged 14 commits into from
Dec 10, 2020

Conversation

ForestEckhardt
Copy link
Contributor

@ForestEckhardt ForestEckhardt commented Oct 29, 2020 •
edited
Loading

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner October 29, 2020 17:08
@ForestEckhardt
Updates BP_GO_BUILD_FLAGS format
1082d01 
- Moves from a comma seperated list to string of the literal flag
structure
ryanmoran
ryanmoran reviewed Oct 30, 2020
View reviewed changes
rfcs/0000-buildpack-yml-to-env-var.md Outdated Show resolved Hide resolved
rfcs/0000-buildpack-yml-to-env-var.md Outdated Show resolved Hide resolved
ryanmoran
ryanmoran previously approved these changes Nov 13, 2020
View reviewed changes
@kvedurmu kvedurmu added the rfc label Nov 18, 2020
@fg-j
Copy link

fg-j commented Nov 18, 2020 •
edited
Loading

One thing to be careful of when implementing this change:

Currently, this buildpack checks whether the shasum of the working directory has changed to determine whether to rebuild the app. A convenient side effect of this criteria is that any changes to buildpack.yml would cause a rebuild of this layer. Doing away with buildpack.yml will open up some more corner cases where build configuration has changed without changing the app source.

fg-j
fg-j previously approved these changes Nov 18, 2020
View reviewed changes
arjun024
arjun024 previously approved these changes Nov 18, 2020
View reviewed changes
@ryanmoran ryanmoran dismissed stale reviews from arjun024 and fg-j via 94c9156 December 10, 2020 18:07
@ForestEckhardt ForestEckhardt merged commit 9137718 into main Dec 10, 2020
@ForestEckhardt ForestEckhardt deleted the buildpack-yml-to-env-var branch December 10, 2020 18:28
@wburningham
Copy link

Should the go version be something that can be explicitly configured with an environment variable as well (I see that it is currently an option in the buildpack.yml, but I don't see it in the RFC)?

@ForestEckhardt
Copy link
Contributor Author

@wburningham I will be opening an RFC in the go-dist repo to convert that over to using environment variables as well.

@fg-j fg-j mentioned this pull request Dec 15, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero left review comments

@genevieve genevieve genevieve left review comments

@ryanmoran ryanmoran ryanmoran approved these changes

@arjun024 arjun024 arjun024 left review comments

@fg-j fg-j fg-j left review comments

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ForestEckhardt @fg-j @wburningham @ryanmoran @jromero @arjun024 @genevieve @kvedurmu