Fix Java Agent Update Checks #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update checker was failing because the format of the source URL was wrong. This change adds a `source_classifier` so that we can locate the correct URL for the source download. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
|
Doh! 🤦 Duplicate of #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Java agent updater is broken.
Use Cases
The update checker was failing because the format of the source URL was wrong. This change adds a
source_classifierso that we can locate the correct URL for the source download.Checklist