Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Add Jammy to Pythonic dependencies #194

Conversation

joshuatcasey
Copy link
Contributor

Fix pip and add Jammy to python, pipenv, and poetry.

@joshuatcasey joshuatcasey requested a review from a team as a code owner July 20, 2022 20:33
@sophiewigmore
Copy link
Member

Is there any context about the version constraints you've chosen? / Are Python maintainers aligned with these version constraints?

@joshuatcasey
Copy link
Contributor Author

I chose the latest version available in each of the buildpacks, since that the integration tests should use. I don't want to indicate version compatibility unless we've actually run integration tests or done some kind of analysis.

@joshuatcasey joshuatcasey self-assigned this Jul 22, 2022
@sophiewigmore
Copy link
Member

sophiewigmore commented Jul 22, 2022

@joshuatcasey thinking about this more, I believe the version the constraints introduced here were a way to only mark Jammy as compatible with specific version lines like in #179.

I don't really think the constraints are necessary here, because the same versions will be affected either way (whether we have constraints listed or not). If you'd like to keep them that's fine though

@joshuatcasey
Copy link
Contributor Author

I'm comfortable having some constraints and then relaxing the constraints later if we need to.

I can't merge this PR though, could a @paketo-buildpacks/dependencies team member do so?

@sophiewigmore sophiewigmore merged commit eff2c07 into paketo-buildpacks:main Jul 22, 2022
@joshuatcasey joshuatcasey deleted the jtc/update-pythonic-dependencies branch July 22, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants