Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Allow for dependencies to not be compiled #183

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

sophiewigmore
Copy link
Member

Summary

As a part of paketo-buildpacks/dotnet-core#722, the SDK dependency should not be compiled anymore. Instead, it's URI and SHA256 should be the same as the upstream ones.

This PR does two things:

  • provides a mechanism to allow dependencies to not be compiled
  • marks the .NET SDK dependency as non-compiled.

I have tested the templating behaviour locally.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@fg-j
Copy link

fg-j commented Jul 8, 2022

Nice! This is a lot simpler than I imagined it would be. 🙂

@sophiewigmore
Copy link
Member Author

@fg-j inspired just a wee bit from #179

@sophiewigmore sophiewigmore marked this pull request as ready for review July 14, 2022 20:20
@sophiewigmore sophiewigmore requested a review from a team as a code owner July 14, 2022 20:20
@sophiewigmore
Copy link
Member Author

bump @brayanhenao :)

@brayanhenao brayanhenao merged commit bb31608 into main Jul 18, 2022
@brayanhenao brayanhenao deleted the use-upstream-sdk branch July 18, 2022 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants