-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: Install packages into working directory #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiewigmore
force-pushed
the
modify-build
branch
from
December 14, 2022 20:55
53280be
to
24d2f72
Compare
sophiewigmore
changed the title
WIP - install packages into working directory
Bug fix: Install packages into working directory
Dec 14, 2022
- Test against framework apps - Update vendored packages on rebuild
sophiewigmore
force-pushed
the
modify-build
branch
from
December 14, 2022 21:04
24d2f72
to
8919225
Compare
The tests are passing locally :/ investigating |
thitch97
previously approved these changes
Dec 20, 2022
This all looks good to me! Just had one question |
thitch97
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#46
/workspace/vendor
directly. This is done to prevent symlinking issues with composer, in which packages installed into the layer cannot find files in/workspace
like.env
and classes outside ofvendor
./workspace/vendor
directory is manually copied into a layer for cachingDrupal app(removed because it was enormous, and was previously failing for the same symlinking issues as the other two apps)#90
/workspace/vendor
dir is cleared and the cachedvendor
directory from the layer is copied into/workspace
.Open questions:
vendor
to layerUse Cases
Checklist