Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick Java 8 extended downloads #136

Closed
dmikusa opened this issue Nov 23, 2022 · 0 comments · Fixed by #140
Closed

Pick Java 8 extended downloads #136

dmikusa opened this issue Nov 23, 2022 · 0 comments · Fixed by #140
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Nov 23, 2022

Expected Behavior

The CI for updating Java 8 does not consistently select between Dragonwell's Java 8 standard and extended. See #134.

Current Behavior

It may pick standard, it may pick extended.

Possible Solution

It should consistently pick extended. The regular expression used needs to be modified.

Steps to Reproduce

See #134

Motivations

We believe users of this buildpack will choose Dragonwell for its extended support, so we want to expose that through the buildpack.
@dmikusa dmikusa added type:bug A general bug note:ideal-for-contribution An issue that a contributor can help us with note:good-first-issue A good first issue to get started with labels Nov 23, 2022
dmikusa added a commit that referenced this issue Dec 7, 2022
@dmikusa
Use the extended version of Java 8
c9689bd 
Change the regex to filter the extended version of Java 8.

Resolves #136

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa mentioned this issue Dec 7, 2022
Merged
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the extended version of Java 8 paketo-buildpacks/alibaba-dragonwell
2 participants
@anthonydahanne @dmikusa