Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slovak translation #291

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Update Slovak translation #291

merged 5 commits into from
Nov 11, 2024

Conversation

Svec-Tomas
Copy link
Contributor

Translated the new tooltips strings

@pakerwreah
Copy link
Owner

There's a new one:
//"calendars.source.others" = "Others";

Could you translate it as well?

@pakerwreah pakerwreah changed the title Update Localizable.strings Update Slovak translation Nov 11, 2024
@Svec-Tomas
Copy link
Contributor Author

There's a new one: //"calendars.source.others" = "Others";

Could you translate it as well?

Sure, but what's the right way to do it now, please? I see it is approved, but I don't see my previous translation implemented here yet:

https://github.com/pakerwreah/Calendr/blob/master/Calendr/Assets/sk.lproj/Localizable.strings

@pakerwreah
Copy link
Owner

ChatGPT told me "Iné" was a good fit, do you agree?

@Svec-Tomas
Copy link
Contributor Author

ChatGPT told me "Iné" was a good fit, do you agree?

It would be in most cases a correct translation, but here it is "Ostatné", just double checked with Apple Calendar as well:

CleanShot 2024-11-11 at 20 07 07@2x

@pakerwreah
Copy link
Owner

For you to keep editing the file from a PR, you just go to the last tab "Files changed", tap the 3 dots and "Edit file".

Files changed Edit file
Screenshot 2024-11-11 at 19 05 25 Screenshot 2024-11-11 at 19 06 11

Try to fix my mistake by doing that.

@Svec-Tomas
Copy link
Contributor Author

While we speak about Calendars, do you have maybe any idea from where this Subscribed Calendars string comes from?

I do not see it in my Apple Calendar for example, but it is present in Calendr.

CleanShot 2024-11-11 at 20 09 27@2x

@pakerwreah
Copy link
Owner

That comes from Apple's imagination 🤣

The subscribed calendars will now be under the "Others" section, with a "wave" icon next to it, like the one we have in the native app.

Copy link
Contributor Author

@Svec-Tomas Svec-Tomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and replaced "Iné" by "Ostatné"

@pakerwreah pakerwreah enabled auto-merge (squash) November 11, 2024 19:16
@pakerwreah pakerwreah merged commit 7034474 into pakerwreah:master Nov 11, 2024
1 check passed
@pakerwreah
Copy link
Owner

I think you missed a "t" though, I'm gonna fix it on the main branch.

@Svec-Tomas
Copy link
Contributor Author

I think you missed a "t" though, I'm gonna fix it on the main branch.

Hahaha, you are right, you have an eagle eye! 👍

pakerwreah added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants