feat: move typescript to an optional peer dependency #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors how typescript-estree depends on typescript:
https://github.com/typescript-eslint/typescript-eslint/blob/946ee3b68823a48fad2cb7b99589e56a68fb11e3/packages/typescript-estree/package.json#L69-L73
typescript-estree prints a warning if it doesn't like the currently
installed typescript version, which seems like good behaviour.
This has two advantages:
And some disadvantages:
npx madge
won't support typescript? Or will error on start. Can't test now, because this change would also need to be applied to e.g. detective-typescript.NB: Typescript don't do semver, so the gap from 3.9 to 4.0 is the same as
the gap from 4.0 to 4.1 or 3.8 to 3.9.