feat: improve prometheus variable naming #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
add_device_label_2
branch
from
0b3ecb0 to
7744e46
Compare
|
@paha I've just submitted two pull requests to handle the dynamic nature of UNIX devices that might change with reboots. While this pull request is superior, it lacks backward compatibility and must be released as a new major version. |
This commit enhances Prometheus variable naming by adding the device as a label instead of including it in the variable name. This change accommodates the dynamic nature of UNIX devices that may change with reboots.
rickstaa
force-pushed
the
add_device_label_2
branch
from
7744e46 to
ab05b29
Compare
paha
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request is a better alternative to #4. It, however, is not backwards compatible since the metric name is changed.
This pull request enhances Prometheus variable naming by adding the device as a label instead of including it in the variable name. This change accommodates the dynamic nature of UNIX devices that may change with reboots.