Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC-318] Migrated pipelines & terraform code from io-infra #300

Merged
merged 26 commits into from
Sep 3, 2024

Conversation

mamu0
Copy link
Contributor

@mamu0 mamu0 commented Jun 20, 2024

List of Changes

With this PR, the entire Terraform infrastructure, previously located in the io-infra repository, has been moved to the infra/prod folder.
Additionally, two GitHub Actions pipelines have been created to manage the CI/CD flow.
One pipeline executes the Terraform plan and is triggered when a PR is created, and the other pipeline performs the Terraform apply and is triggered when the PR is merged.
Removed old github runner configuration.
Removed all identities created inside the .identity folder.

Motivation and Context

This PR completes the migration plan for the pipelines within io-infra.
By doing so, the code specific to io-sign has been moved from io-infra to its dedicated repository.
This ensures that all code is maintained in the same place as the rest of the project.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 884d7a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pagopa pagopa deleted a comment from github-actions bot Jun 21, 2024
Copy link
Contributor

@Krusty93 Krusty93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest few changes I detailed in comments

Copy link
Contributor

github-actions bot commented Sep 3, 2024

📖 Terraform Plan ('infra/resources/prod') - success

Terraform Plan
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.cosmosdb_account.azurerm_cosmosdb_account.this,
  on .terraform/modules/cosmosdb_account/cosmosdb_account/main.tf line 7, in resource "azurerm_cosmosdb_account" "this":
   7:   enable_free_tier          = var.enable_free_tier

This property has been superseded by `free_tier_enabled` and will be removed
in v4.0 of the AzureRM Provider

(and 23 more similar warnings elsewhere)

Warning: Deprecated attribute

  on .terraform/modules/cosmosdb_account/cosmosdb_account/output.tf line 54, in output "connection_strings":
  54:   value     = azurerm_cosmosdb_account.this.connection_strings

The attribute "connection_strings" is deprecated. Refer to the provider
documentation for details.

(and one more similar warning elsewhere)

@mamu0 mamu0 merged commit 468acc0 into main Sep 3, 2024
8 checks passed
@mamu0 mamu0 deleted the EC-318-pipeline-terraform-migration branch September 3, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants