-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EC-318] Migrated pipelines & terraform code from io-infra #300
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest few changes I detailed in comments
…with new environment and deleted old ones
📖 Terraform Plan ('infra/resources/prod') - successTerraform PlanNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
Warning: Argument is deprecated
with module.cosmosdb_account.azurerm_cosmosdb_account.this,
on .terraform/modules/cosmosdb_account/cosmosdb_account/main.tf line 7, in resource "azurerm_cosmosdb_account" "this":
7: enable_free_tier = var.enable_free_tier
This property has been superseded by `free_tier_enabled` and will be removed
in v4.0 of the AzureRM Provider
(and 23 more similar warnings elsewhere)
Warning: Deprecated attribute
on .terraform/modules/cosmosdb_account/cosmosdb_account/output.tf line 54, in output "connection_strings":
54: value = azurerm_cosmosdb_account.this.connection_strings
The attribute "connection_strings" is deprecated. Refer to the provider
documentation for details.
(and one more similar warning elsewhere) |
List of Changes
With this PR, the entire Terraform infrastructure, previously located in the io-infra repository, has been moved to the infra/prod folder.
Additionally, two GitHub Actions pipelines have been created to manage the CI/CD flow.
One pipeline executes the Terraform plan and is triggered when a PR is created, and the other pipeline performs the Terraform apply and is triggered when the PR is merged.
Removed old github runner configuration.
Removed all identities created inside the .identity folder.
Motivation and Context
This PR completes the migration plan for the pipelines within io-infra.
By doing so, the code specific to io-sign has been moved from io-infra to its dedicated repository.
This ensures that all code is maintained in the same place as the rest of the project.
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: