Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-778] Adds possible webUrl action on StatusMessage component #6453

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR adds the possibility to specify a web_url to be opened by tapping on StatusMessage displayed on top of the header

List of changes proposed in this pull request

  • useStatusAlertProps hook has been updated

How to test

Edit the backend.json payload on the io-dev-api-server

@pagopa-github-bot pagopa-github-bot changed the title [IOPLT-778] Adds possible webUrl action on StatusMessage component chore: [IOPLT-778] Adds possible webUrl action on StatusMessage component Nov 25, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 25, 2024

Affected stories

  • ⚙️ IOPLT-778: Gli status banner devono poter gestire l'azione di apertura di un url in browser esterno

Generated by 🚫 dangerJS against 97629f0

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.08%. Comparing base (4f204b4) to head (97629f0).
Report is 785 commits behind head on master.

Files with missing lines Patch % Lines
ts/hooks/useStatusAlertProps.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6453      +/-   ##
==========================================
- Coverage   48.42%   48.08%   -0.35%     
==========================================
  Files        1488     1627     +139     
  Lines       31617    32594     +977     
  Branches     7669     7480     -189     
==========================================
+ Hits        15311    15673     +362     
- Misses      16238    16863     +625     
+ Partials       68       58      -10     
Files with missing lines Coverage Δ
ts/hooks/useStatusAlertProps.ts 57.14% <0.00%> (ø)

... and 1685 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113d171...97629f0. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants