chore(Cross): [IOAPPX-414] Add NativeStackNavigator to the Design System section
#6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
pagopa-github-bot
changed the title
NativeStackNavigator to the Design System sectionNativeStackNavigator to the Design System section
Affected stories
|
dmnplb
requested review from
a team,
ChrisMattew,
gispada and
freddi301
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6340 +/- ##
==========================================
- Coverage 48.42% 47.76% -0.66%
==========================================
Files 1488 1585 +97
Lines 31617 32333 +716
Branches 7669 7375 -294
==========================================
+ Hits 15311 15445 +134
- Misses 16238 16847 +609
+ Partials 68 41 -27
... and 1699 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a reproposal of the following PR, merged and then reverted after concerns about Android builds:
NativeStackNavigatorto the Design System section #5424Short description
This PR adds the new
NativeStackNavigatorto the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.List of changes proposed in this pull request
@react-navigation/native-stackdependencyreact-native-screensdependency with the latest versionHow to test
Launch the app, go to the Design System section and check if everything is OK.