feat: [IOPID-1725] New DS on CIE certificates KO screen #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladirico
changed the title
Ladirico
changed the title
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5775 +/- ##
==========================================
+ Coverage 48.42% 49.54% +1.11%
==========================================
Files 1488 1604 +116
Lines 31617 31879 +262
Branches 7669 7656 -13
==========================================
+ Hits 15311 15793 +482
+ Misses 16238 16032 -206
+ Partials 68 54 -14
... and 435 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shadowsheep1
requested changes
May 17, 2024
|
@mariateresaventura review copy please 😁🙏🏼 |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Integrate new DS on CIE certificates KO screen
Note
To test this case, I replaced the wrong pin screen with this one (the CIE certificate KO screen), so the video flow is wrong, but the important thing was to show the screen!
Note
Accessibility tests have not been performed because the template of this screen has been tested many other times and works.
Screens
android_cie_expired.mp4
ios_cie_expired.mov
How to test
Run this command
yarn cie-ios:prodand after this run the application with production environment and then, if you, like me, do not have an expired or revoked CIE, change this setState with this setState and insert the uncorrect PIN before scan the card.If you have an expired or revoked CIE, run the flow normally.