Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mixpanel setup #3138

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Update mixpanel setup #3138

merged 3 commits into from
Jun 14, 2021

Conversation

Undermaken
Copy link
Contributor

Short description

This PR updates the Mixpanel setup on Android.
On iOS it always worked as expected, on Android it needs an extra configuration in Android Manifest file

more info

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 14, 2021

Warnings
⚠️ Please include a Pivotal story or Jira ticket at the beginning of the PR title

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against e0a1faf

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #3138 (e0a1faf) into master (3dfa5d4) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3138   +/-   ##
=======================================
  Coverage   60.28%   60.28%           
=======================================
  Files         983      983           
  Lines       26618    26619    +1     
  Branches     4893     4893           
=======================================
+ Hits        16047    16048    +1     
  Misses      10465    10465           
  Partials      106      106           
Impacted Files Coverage Δ
ts/mixpanel.ts 60.86% <50.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfa5d4...e0a1faf. Read the comment docs.

@fabriziofff fabriziofff merged commit 287528a into master Jun 14, 2021
@fabriziofff fabriziofff deleted the IA-16-update-mixpanel-config branch January 21, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants