Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPFD0-172] Add loading state to the ButtonSolid (with custom transitions) #99

Merged
merged 7 commits into from
Oct 10, 2023
Merged

[IOAPPFD0-172] Add loading state to the ButtonSolid (with custom transitions) #99

merged 7 commits into from
Oct 10, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 9, 2023 •
edited
Loading

Short description

This PR adds a new loading state to the ButtonSolid component

List of changes proposed in this pull request

  • Slightly refactor the ButtonSolid component to deal with the new LoadingSpinner component
  • Add custom enter/exit transitions used for the state transition in the new IOTransitions file
  • Update relative jest snapshots

Preview

loading-state-button-solid.mp4

How to test

  1. Launch the example app
  2. Go to the Buttons page

@dmnplb dmnplb marked this pull request as ready for review October 10, 2023 08:29
@dmnplb dmnplb requested review from a team as code owners October 10, 2023 08:29
@dmnplb dmnplb merged commit 47384e4 into main Oct 10, 2023
2 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-172-add-loading-state-button-solid branch October 10, 2023 12:57
@dmnplb dmnplb mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani