Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-274] Make Button… accessibilityLabel prop optional + Improve accessibility of selection components (except ListItemSwitch) #235

Merged
merged 14 commits into from
Apr 5, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Apr 3, 2024

Short description

This PR makes Button… accessibilityLabel prop optional and improves accessibility of Selection components.

List of changes proposed in this pull request

  • accessibilityLabel of ButtonSolid and ButtonOutline is optional now, with fallback to label
  • Improve accessibility of ListItemCheckbox and ListItemRadio (ListItemRadioWithAmount included)
  • Add accessibility props to RadioButtonLabel
  • Add fallback accessibilityLabel to ListItemCheckbox
  • Improve accessibility of the ModuleAttachment during loading state
  • Add accessibility props to PressableModuleBase
  • Make accessibilityLabel prop optional in the ListItemNav component

How to test

Check all the mentioned components with VoiceOver enabled

@dmnplb dmnplb added the a11y label Apr 3, 2024
@dmnplb dmnplb changed the title [IOAPPX-274] Make Button… accessibilityLabel prop optional + Improve accessibility of selection components [IOAPPX-274] Make Button… accessibilityLabel prop optional + Improve accessibility of selection components (except ListItemSwitch) Apr 3, 2024
@dmnplb dmnplb marked this pull request as ready for review April 3, 2024 09:50
@dmnplb dmnplb requested review from a team as code owners April 3, 2024 09:50
@dmnplb dmnplb merged commit 4089ec6 into main Apr 5, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-274-make-accessibility-label-optional branch April 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants