Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-236] Adds the new OTPInput component #161

Merged
merged 9 commits into from
Dec 11, 2023
Merged

[IOPLT-236] Adds the new OTPInput component #161

merged 9 commits into from
Dec 11, 2023

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Dec 5, 2023 •
edited
Loading

Short description

This PR implements the new OTPInput component.

List of changes proposed in this pull request

  • BoxedInput component for number/secret representation
  • OTPInput component to mask a real hidden TextInput

How to test

Check the example app related page

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-12-05.at.09.43.44.mp4

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners December 5, 2023 08:42
StefanoFrontini
StefanoFrontini reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@StefanoFrontini StefanoFrontini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking on an input box and then pressing a keybord key nothing happens (only the , and . seems to work)

@CrisTofani
Copy link
Contributor Author

When clicking on an input box and then pressing a keybord key nothing happens (only the , and . seems to work)

addressed in 440757f

StefanoFrontini
StefanoFrontini reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@StefanoFrontini StefanoFrontini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • removes useEffect from OTPInput.tsx
  • replace React.createRef with React.useRef

@CrisTofani CrisTofani merged commit 82d9bcb into main Dec 11, 2023
2 checks passed
@CrisTofani CrisTofani deleted the IOPLT-236 branch December 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanoFrontini StefanoFrontini StefanoFrontini approved these changes

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrisTofani @dmnplb @StefanoFrontini