Skip to content

Commit

Permalink
[IOAPPX-264] Disable the exiting transition in the ButtonSolid co…
Browse files Browse the repository at this point in the history
…mponent to prevent glitch (#223)

## Short description
This PR disables the `exiting` transition on the inner text of the
`ButtonSolid` to prevent a weird glitch when the component is unmounted
on the exit page transition.

## List of changes proposed in this pull request
- Disable `exiting` transition

## How to test
N/A
  • Loading branch information
dmnplb authored Mar 20, 2024
1 parent 7fcee91 commit b02cbbf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/components/buttons/ButtonSolid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ export const ButtonSolid = React.forwardRef<View, ButtonSolidProps>(
entering={
isMounted.current ? enterTransitionInnerContent : undefined
}
exiting={exitTransitionInnerContent}
/* Temporarily disable the exiting transition because it caused
a weird glitch on page exit */
// exiting={exitTransitionInnerContent}
>
{icon && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ exports[`Test Buttons Components - Experimental Enabled ButtonSolid Snapshot 1`]
}
>
<View
exiting={[Function]}
style={
[
{
Expand Down Expand Up @@ -1348,7 +1347,6 @@ exports[`Test Buttons Components ButtonSolid Snapshot 1`] = `
}
>
<View
exiting={[Function]}
style={
[
{
Expand Down

0 comments on commit b02cbbf

Please sign in to comment.