This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
🐛 Fixed root option trailing slash issue #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting the root to '/' the urls would be transformed to '//...' which will break relative paths and make them absolute URLs unintentionally. This commit contains trailing slash trimming for the root option, so that concatenating the root+/+url would be safe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the root to
/the urls would be transformed to//urlwhich will break relative paths and make them absolute URLs unintentionally.This commit contains trailing slash trimming for the root option, so that concatenating the
root+ '/' +urlwould be safe.Also checking regex for absolute paths w/
testis more performant than trying to get thematches.