Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc): sign transaction using wallet client #945

Merged
merged 9 commits into from
Jan 20, 2024
Merged

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jan 18, 2024

Description

This PR adds a signing raw transaction function to the wallet gRPC server.
This enhancement enables merchants to use the Pactus node for issuing and signing transactions.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #945 (d7cacea) into main (a515313) will decrease coverage by 1.95%.
The diff coverage is 77.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   83.42%   81.48%   -1.95%     
==========================================
  Files         171      172       +1     
  Lines        8840     9158     +318     
==========================================
+ Hits         7375     7462      +87     
- Misses       1110     1339     +229     
- Partials      355      357       +2     

Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f thanks

@b00f b00f merged commit 21e3223 into main Jan 20, 2024
12 checks passed
@b00f b00f deleted the grpc-wallet-sign-tx branch January 20, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants