Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): preventing self dial #924

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 9, 2024

Description

This PR will fix self dial issue in the network module.

Related issue(s)

@kehiy kehiy added bug Something isn't working network labels Jan 9, 2024
@kehiy kehiy requested review from b00f and themantre January 9, 2024 15:08
@kehiy kehiy self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #924 (d5ba739) into main (8e25190) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d5ba739 differs from pull request most recent head 28a7876. Consider uploading reports for the commit 28a7876 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   83.37%   83.37%   -0.01%     
==========================================
  Files         172      172              
  Lines        8826     8830       +4     
==========================================
+ Hits         7359     7362       +3     
  Misses       1112     1112              
- Partials      355      356       +1     

@kehiy
Copy link
Contributor Author

kehiy commented Jan 9, 2024

@b00f still getting some /home/runner/work/pactus/pactus/types/certificate/certificate_test.go:270 errors.

@kehiy kehiy merged commit 74f74da into pactus-project:main Jan 9, 2024
10 checks passed
@kehiy kehiy deleted the hotfix/selfdial branch January 9, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants