Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactoring state tests #886

Merged
merged 3 commits into from
Dec 31, 2023
Merged

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Dec 31, 2023

Description

This PR refactors the state tests and clean them ;)

@b00f
Copy link
Collaborator Author

b00f commented Dec 31, 2023

@kehiy as requested before! Please review

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Merging #886 (c57a3bf) into main (a5cc211) will increase coverage by 0.27%.
The diff coverage is 94.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   83.17%   83.45%   +0.27%     
==========================================
  Files         171      171              
  Lines        8673     8673              
==========================================
+ Hits         7214     7238      +24     
+ Misses       1113     1091      -22     
+ Partials      346      344       -2     

@b00f b00f requested a review from amirvalhalla December 31, 2023 08:25
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f thanks, state tests are much more readable now!
applying changes also is more easy.

@b00f b00f merged commit 5348228 into pactus-project:main Dec 31, 2023
12 checks passed
@b00f b00f deleted the refactoring-state-tests branch December 31, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants