Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding querier to query messages #878

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: adding querier to query messages #878

merged 1 commit into from
Dec 29, 2023

Conversation

themantre
Copy link
Contributor

Description

Add querier to QueryVote and QueryProposal messages by including the address of the querier. This serves two purposes:

  1. Provides which node is querying the vote or proposal.
  2. Prevents message ID collisions when multiple nodes query the same vote or proposal, since the querier address are not the same.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Merging #878 (3c95e83) into main (45ddf43) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   83.25%   83.22%   -0.04%     
==========================================
  Files         170      170              
  Lines        8554     8556       +2     
==========================================
- Hits         7122     7121       -1     
- Misses       1094     1096       +2     
- Partials      338      339       +1     

@themantre themantre merged commit efa51e3 into main Dec 29, 2023
12 checks passed
@themantre themantre deleted the querier-msg branch December 29, 2023 07:25
themantre added a commit that referenced this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant