Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: corrected mistake when retrieving the reward address #848

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: corrected mistake when retrieving the reward address #848

merged 2 commits into from
Dec 11, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Dec 11, 2023

Description

This PR fixes a mistake in retrieving the reward address. It also adds tests for the imported private key.

b00f
b00f commented Dec 11, 2023
View reviewed changes
cmd/cmd.go Show resolved Hide resolved
amirvalhalla
amirvalhalla requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f
please resolve requested changes.

cmd/cmd.go Show resolved Hide resolved
@amirvalhalla amirvalhalla merged commit 50d3af1 into pactus-project:main Dec 11, 2023
10 checks passed
@b00f b00f deleted the fix-reward-addr-issue branch January 11, 2024 11:20
@kehiy kehiy mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirvalhalla amirvalhalla amirvalhalla approved these changes

@kehiy kehiy Awaiting requested review from kehiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b00f @amirvalhalla