fix(network): subscribing to the Libp2p event bus #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantre
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 82.85% 82.75% -0.11%
==========================================
Files 172 172
Lines 8364 8383 +19
==========================================
+ Hits 6930 6937 +7
- Misses 1112 1120 +8
- Partials 322 326 +4 |
b00f
reviewed
Nov 29, 2023
b00f
approved these changes
Nov 29, 2023
kehiy
requested changes
Nov 29, 2023
Co-authored-by: Rostam <[email protected]>
Co-authored-by: Rostam <[email protected]>
Co-authored-by: Rostam <[email protected]>
kehiy
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Subscribing to the EventBus of LibP2P helped us figure out when we have a healthy direct connection with a peer. This enables us to send the
connectevent more effectively and initiate handshaking with a peer.