fix(consensus): not increase the voting power on duplicated binary votes #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantre
force-pushed
the
duplicated-binary-votes
branch
from
b383681
to
ec52426
Compare
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 82.75% 82.88% +0.13%
==========================================
Files 173 173
Lines 8049 8058 +9
==========================================
+ Hits 6661 6679 +18
+ Misses 1066 1059 -7
+ Partials 322 320 -2 |
amirvalhalla
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in Binary votes where double votes could increase the voting power.