fix: cache certificate by height #730

themantre · 2023-10-05T03:53:24Z

Description

This PR implements a more accurate approach to caching the certificate by its height.
It also removes the height parameter from the CommitBlock function, as the certificate already contains the height of the committing block.

codecov · 2023-10-05T12:19:41Z

Codecov Report

Merging #730 (9e81a7b) into main (a25efe2) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 92.70%.

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   83.05%   83.03%   -0.02%     
==========================================
  Files         172      172              
  Lines        8020     8024       +4     
==========================================
+ Hits         6661     6663       +2     
- Misses       1043     1044       +1     
- Partials      316      317       +1

state/facade.go

state/state.go

store/interface.go

store/store.go

amirvalhalla

@themantre
thanks, please resolve request changes.

themantre · 2023-10-05T13:35:52Z

@amirvalhalla resolved, please check

amirvalhalla

@themantre
thanks, everything looks good.

themantre added 2 commits October 5, 2023 11:51

fix: cache certificate by height

a549c8f

fix: removing height parameter in CommitBlock func

1aa8c9e

test: fixing a random faulty tests

98a62e9

amirvalhalla self-requested a review October 5, 2023 13:18