fix: fixing a crash on consensus #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 83.05% 83.09% +0.03%
==========================================
Files 172 172
Lines 8020 8026 +6
==========================================
+ Hits 6661 6669 +8
+ Misses 1043 1042 -1
+ Partials 316 315 -1 |
themantre
force-pushed
the
fix-crash-consensus
branch
from
2d14933
to
cc5b212
Compare
b00f
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A crash could occur in the consensus if a validator receives all pre-votes for zero before receiving a proposal. In this case, the node crashed because the prepared block hash was nil.
A test is written to reproduce the crash.