fix: resolve consensus halt caused by time discrepancy in network. #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is a time discrepancy in the network, even for a few seconds, there is a high chance that some validators missed votes or proposals. Prior to this PR, votes and proposals that did not belong to the current height were discarded.
This PR enhances the consensus with two improvements:
newHeight
timer expires.consensusManager
, we populate all votes and proposals belonging to upcoming heights and process them when the consensus moves to the new height.Another improvement is the PIP that prevents nodes with a high time discrepancy from joining the network.