Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CreateValidatorEvent and CreateAccountEvent for nanomsg #702

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 18, 2023

Description

Create an account and validate the event for nanomsg.

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@kehiy kehiy added www high priority It has high priority labels Sep 18, 2023
@kehiy kehiy requested review from b00f and Ja7ad September 18, 2023 09:21
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #702 (970c791) into main (1627d50) will decrease coverage by 0.13%.
The diff coverage is 20.00%.

❗ Current head 970c791 differs from pull request most recent head 73deefd. Consider uploading reports for the commit 73deefd to get more accurate results

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   83.64%   83.51%   -0.13%     
==========================================
  Files         169      169              
  Lines        7899     7916      +17     
==========================================
+ Hits         6607     6611       +4     
- Misses        999     1011      +12     
- Partials      293      294       +1     

@kehiy kehiy self-assigned this Sep 18, 2023
@kehiy
Copy link
Contributor Author

kehiy commented Sep 18, 2023

@b00f @Ja7ad can you have a review?

@b00f b00f merged commit 0ae9f82 into pactus-project:main Sep 18, 2023
10 checks passed
@kehiy kehiy deleted the feature/nanomsgACCVALEvent branch September 19, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority It has high priority www
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding CreateValidatorEvent and CreateAccountEvent for nanomsg
3 participants