-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implementing PIP-2 and PIP-3 #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@b00f |
* fix updating executor and tests * chore: fixing linting issues
Codecov Report
@@ Coverage Diff @@
## main #699 +/- ##
==========================================
+ Coverage 83.47% 83.61% +0.14%
==========================================
Files 168 169 +1
Lines 7983 7899 -84
==========================================
- Hits 6664 6605 -59
+ Misses 1015 1000 -15
+ Partials 304 294 -10 |
b00f
changed the title
feat!: implementing PIP-1 and PIP-3
feat!: implementing PIP-2 and PIP-3
Sep 16, 2023
b00f
requested changes
Sep 16, 2023
@amirvalhalla Thanks |
b00f
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements PIP-2 and PIP-3 by adding the
LockTime
field to the transaction structure.Related issue(s)
If this Pull Request is related to an issue, mention it here.