Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implementing PIP-2 and PIP-3 #699

Merged
merged 5 commits into from
Sep 16, 2023

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Sep 14, 2023

Description

This PR implements PIP-2 and PIP-3 by adding the LockTime field to the transaction structure.

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@amirvalhalla
Copy link
Member Author

@b00f
still some unit tests fail. I didn't fix them because I've wanted you see them, maybe I make mistake in business logic.

@b00f b00f changed the title Feat pip 2 and 3 feat!: implementing PIP-1 and PIP-3 Sep 15, 2023
* fix updating executor and tests

* chore: fixing linting issues
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #699 (af6a43c) into main (019ab6b) will increase coverage by 0.14%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   83.47%   83.61%   +0.14%     
==========================================
  Files         168      169       +1     
  Lines        7983     7899      -84     
==========================================
- Hits         6664     6605      -59     
+ Misses       1015     1000      -15     
+ Partials      304      294      -10     

@b00f b00f changed the title feat!: implementing PIP-1 and PIP-3 feat!: implementing PIP-2 and PIP-3 Sep 16, 2023
cmd/wallet/tx.go Outdated Show resolved Hide resolved
execution/execution.go Outdated Show resolved Hide resolved
sandbox/sandbox.go Outdated Show resolved Hide resolved
sandbox/sandbox.go Show resolved Hide resolved
txpool/pool_test.go Show resolved Hide resolved
types/account/account_test.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Sep 16, 2023

@amirvalhalla Thanks

@b00f b00f merged commit 1627d50 into pactus-project:main Sep 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PIP-2 and PIP-3
2 participants