Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing wallet-cli issues #686

Merged
merged 2 commits into from
Sep 10, 2023
Merged

fix: fixing wallet-cli issues #686

merged 2 commits into from
Sep 10, 2023

Conversation

themantre
Copy link
Contributor

Description

This PR fixes the issues of wallet-cli and its sub-commands.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #686 (7ba8dd6) into main (673e5cc) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   83.44%   83.43%   -0.01%     
==========================================
  Files         168      168              
  Lines        7941     7945       +4     
==========================================
+ Hits         6626     6629       +3     
- Misses       1012     1013       +1     
  Partials      303      303              

Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @themantre

@kehiy kehiy merged commit af851a5 into main Sep 10, 2023
12 checks passed
@kehiy kehiy deleted the wallet-cli branch September 10, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants