Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better logging by renaming err to error #681

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

themantre
Copy link
Contributor

Description

Renaming err to error improves logging in colorful logs.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #681 (7a3611a) into main (54a0f9e) will not change coverage.
The diff coverage is 30.90%.

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files         168      168           
  Lines        7941     7941           
=======================================
  Hits         6624     6624           
  Misses       1013     1013           
  Partials      304      304           

@amirvalhalla amirvalhalla self-requested a review September 10, 2023 07:31
Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themantre
thanks.

@amirvalhalla amirvalhalla merged commit 673e5cc into main Sep 10, 2023
11 of 12 checks passed
@b00f b00f deleted the log-error branch September 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants