-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: write logs into file #673
Conversation
Codecov Report
@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 83.43% 83.46% +0.02%
==========================================
Files 168 168
Lines 7956 7970 +14
==========================================
+ Hits 6638 6652 +14
Misses 1014 1014
Partials 304 304 |
Configuration can be simplified. 1- The directory always set to |
@b00f |
@@ -1,5 +1,10 @@ | |||
package logger | |||
|
|||
const ( | |||
LogDirectory = "logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need it anymore.
@@ -1,5 +1,10 @@ | |||
package logger | |||
|
|||
const ( | |||
LogDirectory = "logs" | |||
LogFilename = "pactus.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this from config.go
to logger.go
It is not something to be configured.
@b00f |
@amirvalhalla |
@b00f |
OK. Waiting for our last changes. Thanks |
Description
write logs into files with rotation feature which provides optional parameters to configure log file based on time duration or file size
Related issue(s)
If this Pull Request is related to an issue, mention it here.