Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: updating the consensus protocol #668

Merged
merged 5 commits into from
Aug 30, 2023
Merged

fix!: updating the consensus protocol #668

merged 5 commits into from
Aug 30, 2023

Conversation

themantre
Copy link
Contributor

Description

This PR updates the consensus protocol based on the new protocol that is explained here.

BREAKING_CHANGE

@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #668 (fbc7664) into main (7b25860) will increase coverage by 0.38%.
The diff coverage is 89.08%.

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   83.73%   84.12%   +0.38%     
==========================================
  Files         155      163       +8     
  Lines        7328     7904     +576     
==========================================
+ Hits         6136     6649     +513     
- Misses        914      958      +44     
- Partials      278      297      +19

@themantre
Copy link
Contributor Author

It also fixes the certificate errors in #315

@themantre themantre requested review from a team, yenkhoon, b00f, vlasfama, ZigBalthazar, kehiy and amirvalhalla and removed request for a team, yenkhoon and b00f August 28, 2023 13:05
kehiy
kehiy approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

b00f
b00f requested changes Aug 28, 2023
View reviewed changes
consensus/cp_decide.go Outdated Show resolved Hide resolved
consensus/cp_test.go Show resolved Hide resolved
consensus/cp_test.go Outdated Show resolved Hide resolved
consensus/cp_test.go Outdated Show resolved Hide resolved
consensus/mock.go Outdated Show resolved Hide resolved
consensus/precommit.go Outdated Show resolved Hide resolved
consensus/prepare.go Outdated Show resolved Hide resolved
state/lastinfo/last_info_test.go Outdated Show resolved Hide resolved
www/grpc/blockchain_test.go Outdated Show resolved Hide resolved
util/testsuite/testsuite.go Outdated Show resolved Hide resolved
b00f
b00f reviewed Aug 28, 2023
View reviewed changes
types/vote/vote.go Outdated Show resolved Hide resolved
@pactus-project pactus-project deleted a comment from b00f Aug 28, 2023
@b00f b00f added Consensus Breaking Changes It Contains some Changes that might not be backward compatible labels Aug 28, 2023
ZigBalthazar
ZigBalthazar approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@ZigBalthazar ZigBalthazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it appears satisfactory.✌️

amirvalhalla
amirvalhalla requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@amirvalhalla amirvalhalla left a comment •
edited by themantre
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comments.

@themantre
Copy link
Contributor Author

@amirvalhalla Good finds. Thanks.

@themantre
Copy link
Contributor Author

@amirvalhalla Your comments applied. Please take a look again. Thanks

amirvalhalla
amirvalhalla approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@amirvalhalla amirvalhalla left a comment •
edited by themantre
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

kehiy
kehiy requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themantre
this fixes the Linux build and linter issue.

consensus/cp_prevote.go Outdated Show resolved Hide resolved
consensus/propose.go Outdated Show resolved Hide resolved
@themantre
Copy link
Contributor Author

@kehiy your comments are applied. Please check.

kehiy
kehiy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment •
edited by b00f
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themantre

everything looks good.

@b00f b00f merged commit ca5bf56 into main Aug 30, 2023
12 checks passed
@b00f b00f deleted the consensus-update branch August 30, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirvalhalla amirvalhalla amirvalhalla approved these changes

@kehiy kehiy kehiy approved these changes

@ZigBalthazar ZigBalthazar ZigBalthazar approved these changes

@b00f b00f b00f approved these changes

@vlasfama vlasfama Awaiting requested review from vlasfama vlasfama was automatically assigned from pactus-project/core

@yenkhoon yenkhoon Awaiting requested review from yenkhoon

Assignees
No one assigned
Labels
Breaking Changes It Contains some Changes that might not be backward compatible Consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@themantre @b00f @ZigBalthazar @kehiy @amirvalhalla