refactor: change Hello message from broadcasting to direct messaging #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehiy
changed the title
ZigBalthazar
force-pushed
the
feature/messageBroadcast
branch
from
76892e0
to
06ae7f6
Compare
kehiy
reviewed
Aug 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 84.12% 83.91% -0.21%
==========================================
Files 163 163
Lines 7904 7929 +25
==========================================
+ Hits 6649 6654 +5
- Misses 958 977 +19
- Partials 297 298 +1 |
Co-authored-by: Kay <[email protected]>
Co-authored-by: Kay <[email protected]>
kehiy
approved these changes
Aug 30, 2023
b00f
reviewed
Aug 31, 2023
Co-authored-by: b00f <[email protected]>
b00f
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have updated the Hello message from broadcasting to direct messaging. This change will reduce network usage and improve efficiency.