Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notifee service events #628

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Conversation

ZigBalthazar
Copy link
Contributor

@ZigBalthazar ZigBalthazar commented Aug 10, 2023

Description

I added EventTypeConnect and EventTypeDisconnect to the Network events to handle the Connect and Disconnect events.

Related issue(s)

network/notifee.go Outdated Show resolved Hide resolved
network/notifee.go Show resolved Hide resolved
network/interface.go Show resolved Hide resolved
network/interface.go Outdated Show resolved Hide resolved
network/interface.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #628 (9bfb745) into main (b62ed0d) will decrease coverage by 0.01%.
The diff coverage is 68.75%.

❗ Current head 9bfb745 differs from pull request most recent head 7b244d1. Consider uploading reports for the commit 7b244d1 to get more accurate results

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   83.63%   83.62%   -0.01%     
==========================================
  Files         154      155       +1     
  Lines        7270     7286      +16     
==========================================
+ Hits         6080     6093      +13     
- Misses        911      914       +3     
  Partials      279      279              

@kehiy kehiy requested a review from b00f August 10, 2023 17:15
@themantre themantre enabled auto-merge (squash) August 11, 2023 10:09
@themantre themantre merged commit c0aba74 into pactus-project:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect/Disconnect events for Network module
3 participants