-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notifee service events #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 83.63% 83.62% -0.01%
==========================================
Files 154 155 +1
Lines 7270 7286 +16
==========================================
+ Hits 6080 6093 +13
- Misses 911 914 +3
Partials 279 279 |
themantre
approved these changes
Aug 11, 2023
Co-authored-by: b00f <[email protected]>
Co-authored-by: b00f <[email protected]>
themantre
approved these changes
Aug 11, 2023
b00f
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added
EventTypeConnect
andEventTypeDisconnect
to the Network events to handle theConnect
andDisconnect
events.Related issue(s)