Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updating LRU cache to version2 #514 #602

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

sadaghiani
Copy link
Contributor

Description

The following items were included:

  • update the golang-lru package to version 2
  • define two separate caches: one for blocks and another for certificates
  • simply use the height of the block or certificate.

Related issue(s)

sync/cache/cache.go Outdated Show resolved Hide resolved
sync/cache/cache.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #602 (dd974fd) into main (db341c3) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   83.50%   83.45%   -0.06%     
==========================================
  Files         154      154              
  Lines        7277     7275       -2     
==========================================
- Hits         6077     6071       -6     
- Misses        918      920       +2     
- Partials      282      284       +2     

@sadaghiani sadaghiani requested a review from b00f July 28, 2023 04:34
@sadaghiani sadaghiani marked this pull request as draft July 28, 2023 04:40
@sadaghiani sadaghiani marked this pull request as ready for review July 28, 2023 06:39
@b00f b00f enabled auto-merge (squash) July 28, 2023 11:47
@b00f b00f merged commit dcf2242 into pactus-project:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating LRU cache to version2
2 participants