-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: adding MinimumStake parameter #574
Conversation
Please send your PR on mainnet branch. |
@Ja7ad sure! |
Co-authored-by: b00f <[email protected]>
@b00f I commited your sugget, but don't forget to solve test issue in mergeing time. |
I think we can fix test with small modification for func (td *testData) randomAmountAndFee(min int64, max int64) (int64, int64) {
amt := td.RandInt64NonZero(max)
for amt < min {
amt = td.RandInt64NonZero(max)
}
fee := int64(float64(amt) * td.sandbox.Params().FeeFraction)
return amt, fee
} |
@b00f some other tests going to be filled, can you review them? |
@kehiy Please use Thanks buddy |
@b00f I fixed it, the last issue is |
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 83.62% 83.54% -0.09%
==========================================
Files 154 154
Lines 7267 7279 +12
==========================================
+ Hits 6077 6081 +4
- Misses 911 915 +4
- Partials 279 283 +4 |
@b00f checks are passed! |
Description
This PR adds the
MinimumStake
parameter to the consensus parameters and the default value is set to 1 PAC coin (10^9).Consequently, all bond transaction will reject if their value is less than the
MinimumStake
.Related issue(s)
BREAKING CHANGE