Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LastSent and LastReceived properties to peer #569

Merged

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Jul 3, 2023

Description

change LastSeen prop of peer to LastReceived and also related things to LastSeen renamed, add LastSent prop to peer and use it in sendTo() plus updated grpc & HTTP , beside all of these added test for UpdateLastSent()

Related Discussion(s)

#566

@amirvalhalla amirvalhalla changed the title Feature/peer lastsent and lastreceived feat: add lastsent and lastreceived to peer Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #569 (afcfd8a) into main (723463d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   83.48%   83.50%   +0.01%     
==========================================
  Files         154      154              
  Lines        7243     7249       +6     
==========================================
+ Hits         6047     6053       +6     
  Misses        916      916              
  Partials      280      280              

@b00f b00f changed the title feat: add lastsent and lastreceived to peer feat: add LastSent and LastReceived properties to peer Jul 4, 2023
@b00f b00f merged commit 2dd2f3b into pactus-project:main Jul 4, 2023
@b00f
Copy link
Collaborator

b00f commented Jul 4, 2023

@amirvalhalla Thanks. It is exactly what we need.

@amirvalhalla
Copy link
Member Author

@amirvalhalla Thanks. It is exactly what we need.

so how I am lucky to understood well your purpose :)

@b00f
Copy link
Collaborator

b00f commented Jul 4, 2023

I am lucky that you are helping us, I really appreciate. With your help we can make Pactus better.

@amirvalhalla
Copy link
Member Author

amirvalhalla commented Jul 4, 2023

I am lucky that you are helping us, I really appreciate. With your help we can make Pactus better.

I hope could be at Pactus , as core developer

@b00f
Copy link
Collaborator

b00f commented Jul 4, 2023

You are most welcome. Join our Discord @amirvalhalla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants