Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP): Missing handlers #549

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jun 27, 2023

Description

I worte getAccountByNumber and getValidatorByNumber handler and also test for the handlers.

Related issue(s)

feat: #528

@kehiy
Copy link
Contributor Author

kehiy commented Jun 27, 2023

@b00f I think you can review this PR now!

@Ja7ad Ja7ad requested a review from b00f June 27, 2023 10:27
www/http/account.go Outdated Show resolved Hide resolved
www/http/validator.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jun 27, 2023

@kehiy Everything looks good. Please not that HTTP is a just wrapper over gRPC.
So, it is better to just call the gRPC, and let gRPC validates the data

@kehiy
Copy link
Contributor Author

kehiy commented Jun 27, 2023

@kehiy Everything looks good. Please not that HTTP is a just wrapper over gRPC. So, it is better to just call the gRPC, and let gRPC validates the data

that't mean I need just remove the checks and test for them?

@kehiy kehiy requested a review from b00f June 27, 2023 11:18
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #549 (9cd59ac) into main (7281c49) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   83.28%   83.39%   +0.10%     
==========================================
  Files         154      154              
  Lines        7341     7389      +48     
==========================================
+ Hits         6114     6162      +48     
  Misses        947      947              
  Partials      280      280              

www/http/account_test.go Show resolved Hide resolved
www/http/validator_test.go Show resolved Hide resolved
@kehiy kehiy requested a review from b00f June 27, 2023 11:48
@b00f
Copy link
Collaborator

b00f commented Jun 27, 2023

@kehiy Everything looks good. Please not that HTTP is a just wrapper over gRPC. So, it is better to just call the gRPC, and let gRPC validates the data

that't mean I need just remove the checks and test for them?

Correct. It is OK now

@b00f b00f enabled auto-merge (squash) June 27, 2023 11:54
@b00f b00f disabled auto-merge June 27, 2023 11:54
@b00f b00f enabled auto-merge (squash) June 27, 2023 11:54
@b00f b00f changed the title feat(HTTP): Missing handlers fix(HTTP): Missing handlers Jun 27, 2023
@b00f b00f merged commit 1b4e546 into pactus-project:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants