-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gui): update about dialog and menu items in help #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add version, logo and comment in about dialog - add menu item website, explorer and home - add getMenuItem object - add cross platform open url in browser Fixed #519
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 83.15% 83.28% +0.13%
==========================================
Files 154 154
Lines 7306 7341 +35
==========================================
+ Hits 6075 6114 +39
+ Misses 951 947 -4
Partials 280 280 |
b00f
reviewed
Jun 24, 2023
b00f
approved these changes
Jun 24, 2023
b00f
changed the title
feat: update about dialog and menu items in help
fix: update about dialog and menu items in help
Jun 24, 2023
close #531 |
b00f
approved these changes
Jun 26, 2023
b00f
changed the title
fix: update about dialog and menu items in help
fix(gui): update about dialog and menu items in help
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers these changes:
getMenuItem
functionFixed #519