Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): update about dialog and menu items in help #532

Merged
merged 10 commits into from
Jun 26, 2023
Merged

fix(gui): update about dialog and menu items in help #532

merged 10 commits into from
Jun 26, 2023

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 24, 2023

Description

This PR covers these changes:

  • Adding version, logo and comment in about dialog
  • Adding menu items for website, explorer and home
  • Adding getMenuItem function
  • Adding and testing cross platform open URL in browser

Fixed #519

- add version, logo and comment in about dialog
- add menu item website, explorer and home
- add getMenuItem object
- add cross platform open url in browser

Fixed #519
@Ja7ad Ja7ad requested a review from b00f June 24, 2023 08:22
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #532 (630ff9c) into main (5e2f135) will increase coverage by 0.13%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   83.15%   83.28%   +0.13%     
==========================================
  Files         154      154              
  Lines        7306     7341      +35     
==========================================
+ Hits         6075     6114      +39     
+ Misses        951      947       -4     
  Partials      280      280              

cmd/gtk/assets/ui/main_window.ui Outdated Show resolved Hide resolved
cmd/gtk/assets/ui/main_window.ui Outdated Show resolved Hide resolved
cmd/gtk/assets/ui/main_window.ui Outdated Show resolved Hide resolved
@b00f b00f changed the title feat: update about dialog and menu items in help fix: update about dialog and menu items in help Jun 24, 2023
@Ja7ad
Copy link
Contributor Author

Ja7ad commented Jun 25, 2023

close #531

@b00f b00f changed the title fix: update about dialog and menu items in help fix(gui): update about dialog and menu items in help Jun 26, 2023
@b00f b00f merged commit 7281c49 into pactus-project:main Jun 26, 2023
@Ja7ad Ja7ad deleted the refactor/gui branch June 26, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Updating about dialog
2 participants