Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename send to transfer. #469

Merged
merged 6 commits into from
May 19, 2023

Conversation

yenkhoon
Copy link
Contributor

Description

Rename send to transfer.

@yenkhoon yenkhoon requested a review from b00f May 11, 2023 10:13
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #469 (3c6bf47) into main (c2fae1d) will not change coverage.
The diff coverage is 82.14%.

@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         149      149           
  Lines        7007     7007           
=======================================
  Hits         5778     5778           
  Misses        938      938           
  Partials      291      291           

Copy link
Collaborator

@b00f b00f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename NewSendTx to NewTransferTx

cmd/wallet/main.go Outdated Show resolved Hide resolved
cmd/wallet/main.go Outdated Show resolved Hide resolved
cmd/wallet/main.go Outdated Show resolved Hide resolved
cmd/wallet/main.go Outdated Show resolved Hide resolved
cmd/wallet/main.go Outdated Show resolved Hide resolved
types/tx/payload/payload.go Outdated Show resolved Hide resolved
types/tx/payload/payload.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented May 17, 2023

@yenkhoon You forgot to rename NewSendTx to NewTransferTx

@yenkhoon
Copy link
Contributor Author

Okie i will change it

@b00f
Copy link
Collaborator

b00f commented May 19, 2023

@yenkhoon Thanks

@b00f b00f merged commit d628f68 into pactus-project:main May 19, 2023
b00f pushed a commit to b00f/pactus that referenced this pull request May 25, 2023
* refactor: rename send to transfer.

* refractor: rename send to transfer in wallet cmd.

* refractor: use capital Transfer and capital Withdraw in wallet cmd.

* refractor: rename send to transfer.

* refractor: use capital for Bond and Unbond in wallet cmd.

* refractor: rename NewSendTx to NewTransferTx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants