-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename send to transfer. #469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 149 149
Lines 7007 7007
=======================================
Hits 5778 5778
Misses 938 938
Partials 291 291 |
b00f
requested changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename NewSendTx
to NewTransferTx
b00f
reviewed
May 12, 2023
b00f
reviewed
May 12, 2023
@yenkhoon You forgot to rename |
Okie i will change it |
b00f
approved these changes
May 19, 2023
@yenkhoon Thanks |
b00f
pushed a commit
to b00f/pactus
that referenced
this pull request
May 25, 2023
* refactor: rename send to transfer. * refractor: rename send to transfer in wallet cmd. * refractor: use capital Transfer and capital Withdraw in wallet cmd. * refractor: rename send to transfer. * refractor: use capital for Bond and Unbond in wallet cmd. * refractor: rename NewSendTx to NewTransferTx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename send to transfer.