fix(consensus): send decided vote for previous round on query vote #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
reviewed
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
+ Coverage 75.07% 75.92% +0.84%
==========================================
Files 234 236 +2
Lines 12156 18198 +6042
==========================================
+ Hits 9126 13816 +4690
- Misses 2582 3922 +1340
- Partials 448 460 +12 |
Ja7ad
approved these changes
Nov 5, 2024
Ja7ad
requested review from
mohamadkenway,
alidevjimmy,
akbariandev and
FishDontExist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon receiving a QueryVote, if there is any decided vote for the last round, it should be broadcasted. Previously, it broadcast the decided vote for the query round. This helps validators who are behind the network to sync faster.