feat(wallet): add wallet service API #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b00f Can you write more details what is response of:
|
Information about wallet, like Wallet name, version, Is Encrypted, Creation time, etc
For listing wallets, we can list files inside the
The list of all addresses in a wallet. |
b00f
requested changes
Oct 16, 2024
| func (wm *Manager) ListAddress(walletName string) ([]vault.AddressInfo, error) { | ||
| wlt, ok := wm.wallets[walletName] | ||
| if !ok { | ||
| return nil, status.Errorf(codes.NotFound, "wallet is not loaded") |
There was a problem hiding this comment.
One potential refactor is to define proper error types here.
There was a problem hiding this comment.
@b00f Can you explain more about your suggestion?
There was a problem hiding this comment.
We should define error types here.
b00f
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)