-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet, cmd): adding ed25519_account in help and set as default #1485
Conversation
@b00f @akbariandev I reverted the default change. I tried to test the CLI and when I give an input as password, If it is not same as my wallet password it returns invalid password error. I think it consider it as wallet password not a password provided for this address. or maybe I'm using this wrong? |
What is default now? |
@kehiy It must compare provided password with wallet password. Actually this feature can create new Ed25519 address by wallet password. |
@akbariandev This only affects the default and description of command, not the way that it inputs the password from user. maybe I understand your comment wrong? |
@b00f @akbariandev @akbariandev Any updates? should we merge or close this PR? |
@kehiy please add it but not make it as default now. Let's do it in the next release. |
@b00f done. |
Description
The new address type was missed in the wallet cmd help command. Also ed25519 is faster and widely supported in different wallet's, so we can set it as default and new users will have ed25519 address.