refactor(types): using options pattern for memo parameter on new tx functions #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Jul 30, 2024
maxipaz
force-pushed
the
refactor/new-tx-optional-memo
branch
3 times, most recently
from
e3d4cbf
to
ea2ecb0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
+ Coverage 75.30% 75.50% +0.19%
==========================================
Files 220 222 +2
Lines 11472 11511 +39
==========================================
+ Hits 8639 8691 +52
+ Misses 2413 2403 -10
+ Partials 420 417 -3 |
maxipaz
force-pushed
the
refactor/new-tx-optional-memo
branch
from
ea2ecb0
to
804924b
Compare
b00f
requested changes
Jul 31, 2024
|
I proposed to remove some unnecessary memos from the test. Maybe you can align lines in some tests. |
maxipaz
force-pushed
the
refactor/new-tx-optional-memo
branch
from
804924b
to
f9714ef
Compare
maxipaz
force-pushed
the
refactor/new-tx-optional-memo
branch
from
f9714ef
to
a7047b3
Compare
b00f
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making
memofield optional in thenewTxand its callers functions, by using options pattern.Related issue(s)
memoOptional in Creating New Transactions #1440