Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gtk): solve dynamic library dependencies and import path on macOS #1435

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

amirvalhalla
Copy link
Member

@amirvalhalla amirvalhalla commented Jul 25, 2024

Description

solve dynamic library dependencies and import path for gui and gtk on macOS

@amirvalhalla amirvalhalla requested a review from b00f July 25, 2024 12:47
@amirvalhalla amirvalhalla self-assigned this Jul 25, 2024
@amirvalhalla amirvalhalla changed the title fix: solve dynamic library dependencies and import path on macos fix: solve dynamic library dependencies and import path for gui and gtk on macOS Jul 25, 2024
@amirvalhalla amirvalhalla changed the title fix: solve dynamic library dependencies and import path for gui and gtk on macOS fix(gtk): solve dynamic library dependencies and import path on macOS Jul 25, 2024
@@ -33,6 +34,10 @@ func init() {
passwordOpt = flag.String("password", "", "wallet password")
testnetOpt = flag.Bool("testnet", false, "initializing for the testnet")
version.NodeAgent.AppType = "gui"
if runtime.GOOS == "darwin" {
runtime.UnlockOSThread()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change? Can you put some comment here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f done

@amirvalhalla amirvalhalla requested a review from b00f July 25, 2024 13:55
@b00f
Copy link
Collaborator

b00f commented Jul 25, 2024

Thanks @amirvalhalla

@b00f b00f merged commit 89938c4 into pactus-project:main Jul 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants