Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): return error on invalid arguments for VerifyMessage #1411

Merged
merged 5 commits into from
Jul 13, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jul 12, 2024

Description

This PR enhances error handling by returning InvalidArgument error when the Public Key or Signature is invalid.
This improvement allows users to distinguish between an invalid argument and a signature that does not match the signed message.

@Ja7ad Ja7ad added this to the v1.4.0 milestone Jul 12, 2024
@Ja7ad Ja7ad requested a review from b00f July 12, 2024 11:46
@b00f b00f changed the title fix(utils): skip error on verify message when is invalid and return false fix(grpc): return error on invalid arguments for VerifySignature Jul 13, 2024
@b00f b00f changed the title fix(grpc): return error on invalid arguments for VerifySignature fix(grpc): return error on invalid arguments for VerifyMessage Jul 13, 2024
@b00f b00f merged commit 456cc09 into pactus-project:main Jul 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants