Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc): change bytes type to hex string #1371

Merged
merged 10 commits into from
Jun 27, 2024
Merged

fix(grpc): change bytes type to hex string #1371

merged 10 commits into from
Jun 27, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Jun 26, 2024

Description

Change bytes type in grpc to hex string

Related issue(s)

@Ja7ad Ja7ad requested a review from b00f June 26, 2024 13:20
b00f
b00f requested changes Jun 26, 2024
View reviewed changes
crypto/bls/signature.go Outdated Show resolved Hide resolved
crypto/bls/signature.go Outdated Show resolved Hide resolved
crypto/bls/signature.go Outdated Show resolved Hide resolved
crypto/hash/hash.go Outdated Show resolved Hide resolved
crypto/hash/hash.go Outdated Show resolved Hide resolved
types/tx/tx.go Outdated Show resolved Hide resolved
types/tx/tx.go Outdated Show resolved Hide resolved
types/tx/tx.go Outdated Show resolved Hide resolved
b00f
b00f requested changes Jun 26, 2024
View reviewed changes
crypto/hash/hash_test.go Outdated Show resolved Hide resolved
node/peers.json Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jun 26, 2024 •
edited
Loading

@Ja7ad

In tx package you added two methods: FromHex and Hex

The Hex is never used in implementation, FromHex is used only once.
Since tx is a big object, it make sense that we don't add From/To string for tx

So, remove these function.
Inside tests you can use: ts.DecodingHex for decoding hex easily.

@Ja7ad
Copy link
Contributor Author

Ja7ad commented Jun 26, 2024

@b00f done

@b00f b00f merged commit 30a1233 into pactus-project:main Jun 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swagger doesn't accept hex
2 participants
@Ja7ad @b00f